[PATCH] D59483: [llvm-objcopy]Preserve data in segments not covered by sections

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 12:16:55 PDT 2019


jakehehrlich added a comment.

Ok, I think how the test functions is fine and it's probably a good test. It certainly tests every case I'd consider. I haven't checked that all the offsets are correct but they don't look wrong at a glance.

LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59483/new/

https://reviews.llvm.org/D59483





More information about the llvm-commits mailing list