[PATCH] D58848: [DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D58848#1430203 <https://reviews.llvm.org/D58848#1430203>, @avl wrote:

> In case Undef specified then there could be several sections with matching address ranges. 
>  It seems to me that DWARFDebugLineTable improper place to make such a decision - which of them should be taken as a result.
>  This in fact high level decision, not low level.


It still seems too high level to me if it involves the caller separately opening and walking the file contents.

Please move this down at least far enough that it doesn't involve separately computing the file name and opening the file. Where it's a "well, if you didn't specify a section index, we'll use the first section that covers this address".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58848/new/

https://reviews.llvm.org/D58848