[PATCH] D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 19:21:12 PDT 2019


yln marked 2 inline comments as done.
yln added inline comments.


================
Comment at: compiler-rt/lib/interception/interception_linux.h:30
+#define INTERCEPT_FUNCTION_LINUX_OR_FREEBSD(func)                         \
+  (REAL(func) = (FUNC_TYPE(func)) ::__interception::GetFuncAddr(#func))
 
----------------
delcypher wrote:
> Is this right? The previous version didn't have an assignment.
The old version of GetRealFunctionAddress takes a pointer for it's second parameter, which is assigned:
```
*func_addr = (uptr)dlsym(RTLD_DEFAULT, func_name);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59504/new/

https://reviews.llvm.org/D59504





More information about the llvm-commits mailing list