[PATCH] D57940: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 11:17:56 PDT 2019


ruiu added a comment.

Not sure if I follow. Looks like you always instantiate the template using `ELFT::Rela`, so effectively you are assuming that all targets are using RELA (which is a wrong assumption by the way)? I think you need to dispatch using `Config->IsRela`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57940/new/

https://reviews.llvm.org/D57940





More information about the llvm-commits mailing list