[PATCH] D59618: [llvm-objdump] Support llvm-objdump -sj.foo

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 03:11:14 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. I imagine that there might be more options like this, both in llvm-objdump and the other tools?



================
Comment at: llvm/test/tools/llvm-objdump/section-filter.test:1
-// This test checks that --section works correctly
+// This test checks that --section works correctly.
 // RUN: llvm-objdump -h %p/Inputs/section-filter.obj -j=.text \
----------------
While you're modifying this test, would you mind normalising its use of '//' versus '#'? I actually don't think you need either, since nothing is using this file as an input apart from FileCheck, but I don't mind using one, as long as it's the same one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59618/new/

https://reviews.llvm.org/D59618





More information about the llvm-commits mailing list