[PATCH] D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 22:21:43 PDT 2019


asbirlea added a comment.

Thank you for the comments!
Quick answer before addressing the rest of the comments: the missing `clear()` calls were intentional, since they're redundant. The calls that don't call `clear()` are just wrappers over the methods that do call `clear()`. These wrappers are over a single call so there wouldn't be any benefit from not clearing inside the wrapped method, even if we could.
I'm not sure if it's preferable to add the redundant calls for consistency or safety if things change in the future, or add comments explaining why they're not needed today.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59315/new/

https://reviews.llvm.org/D59315





More information about the llvm-commits mailing list