[PATCH] D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 15:17:30 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:843
+      // https://bugs.llvm.org/show_bug.cgi?id=41124
+      Target->relocateOne(BufLoc, Type, SignExtend64<Bits>(UINT64_MAX - 1));
   }
----------------
This expression seems tricky -- maybe 0xfffffffe is easier to read? That number is apparently the largest address minus one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553





More information about the llvm-commits mailing list