[PATCH] D59616: [ARM] Optimize expressions like "return x != 0; " for Thumb1.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 14:45:25 PDT 2019


efriedma created this revision.
efriedma added reviewers: rogfer01, samparker.
Herald added subscribers: jdoerfert, kristof.beyls, javed.absar.
Herald added a project: LLVM.

There's an existing optimization for x != C, but somehow it was missing a special case for 0.

While I'm here, also cleaned up the code/comments a bit: the second value produced by the MERGE_VALUES was actually dead, since a CMOV only produces one result.


Repository:
  rL LLVM

https://reviews.llvm.org/D59616

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  test/CodeGen/ARM/select-imm.ll
  test/CodeGen/Thumb/umulo-128-legalisation-lowering.ll
  test/CodeGen/Thumb/umulo-32-legalisation-lowering.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59616.191587.patch
Type: text/x-patch
Size: 14880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190320/5f7a6131/attachment.bin>


More information about the llvm-commits mailing list