[PATCH] D59574: Fix Mach-O bind and rebase validation errors in libObject

[Pete Cooper via Phabricator via llvm-commits]

pete accepted this revision.
pete added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Object/MachOObjectFile.cpp:3993
+        continue;
+      if (SI.OffsetInSegment <= Start && Start < SI.OffsetInSegment + SI.Size) {
+        if (End <= SI.OffsetInSegment + SI.Size) {
----------------
Can you add some ()'s?  eg:

if ((SI.OffsetInSegment <= Start) && (Start < (SI.OffsetInSegment + SI.Size)))

Otherwise LGTM.  And sorry if this makes 80 cols hard to achieve!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59574/new/

https://reviews.llvm.org/D59574