[PATCH] D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880)

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 05:08:46 PDT 2019


courbet added a comment.

> This may or may not be a correct implementation of dbscan clustering algorithm.

Yes, that's what we want. This really is one cluster.

> While the current default is good for abstract 'analyse clustering of measurements',

i'm not sure how often that is the actual goal, not 'compare llvm data with measurements'.
So i'm not sure what should be the default.

It think that's a fair point: I originally intended to sort of have one cluster be one sched class. But why do you need clusters at all if all you care about is the mismatch between each instruction and its scheduling data ?

Then why do you need clustering at all ? Why not create one cluster by instruction ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59539/new/

https://reviews.llvm.org/D59539





More information about the llvm-commits mailing list