[PATCH] D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked an inline comment as done.
asbirlea added inline comments.


================
Comment at: lib/Analysis/MemorySSA.cpp:1487
 
-  OptimizeUses(this, Walker, AA, DT).optimizeUses();
+  // Note: Optionally create the walker for future users. Then we can remove the
+  // "if(Walker)" in verifyMemorySSA.
----------------
george.burgess.iv wrote:
> If you want to do this, please do it as a part of this CL (looks like it'll require plumbing `AA` through). Otherwise, please remove the note
Added the walker init in the constructor, after setting AA.


================
Comment at: lib/Analysis/MemorySSA.cpp:1803
+  if (Walker)
+    Walker->verify(this);
   // Previously, the verification used to also verify that the clobberingAccess
----------------
george.burgess.iv wrote:
> (I'd be equally happy with `getWalker()->verify(this)`, personally, since I agree that this is a tricky edge case :) )
`getWalker()` is not `const`, and I wanted to keep the `const` qualifier on the `verifyMemorySSA()`. Initializing the walker when building, so I removed the check.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59315/new/

https://reviews.llvm.org/D59315