[PATCH] D59518: [DwarfDebug] Skip entries to big for 16 bit size field in Dwarf < 5.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 13:34:38 PDT 2019


fhahn marked an inline comment as done.
fhahn added a comment.

Thanks for all the feedback!



================
Comment at: llvm/test/MC/X86/dwarf-size-field-overflow.test:9
+# CHECK-NEXT:      DW_AT_location   (0x00000000
+# CHECK-NEXT:           [0x0000000000000000,  0x0000000000000008): )
+# CHECK-NEXT:      DW_AT_name   ("self")
----------------
probinson wrote:
> I could wish for something more obviously "no expression here" but that's not your doing.
Yes something that makes it more obvious would be great!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59518/new/

https://reviews.llvm.org/D59518





More information about the llvm-commits mailing list