[PATCH] D58736: [System Model] Introduce a target system model

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 09:58:19 PDT 2019


Meinersbur added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:407
+
+  unsigned getMaxPrefetchIterationsAhead() const { return UINT_MAX; }
 
----------------
simoll wrote:
> What is this method supposed to return?
> The right value seems to be a property of a specific pair of a loop and a target architecture rather than just the target alone.
It is used by LoopDataPrefetch. `TargetTransformInfo.h` contains a description:
```
  /// \return The maximum number of iterations to prefetch ahead.  If the
  /// required number of iterations is more than this number, no prefetching is
  /// performed.
  unsigned getMaxPrefetchIterationsAhead() const;
```
I assume it was added just because the current code base already defines it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58736/new/

https://reviews.llvm.org/D58736





More information about the llvm-commits mailing list