[PATCH] D59488: [llvm-objcopy] - Calculate the string table section sizes correctly.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 01:20:29 PDT 2019


grimar added a comment.

In D59488#1433463 <https://reviews.llvm.org/D59488#1433463>, @jakehehrlich wrote:

> Maybe we should make "prepareForLayout" a top level operation that we can just run on all sections?


I thought about this, but the problem is call order: we should call it for symbol table earlier than for string table sections, for example.
i.e. it would not make the code to be a simple loop.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59488/new/

https://reviews.llvm.org/D59488





More information about the llvm-commits mailing list