[PATCH] D59534: Enable tail call in MemCpyOptimization

[Hideto Ueno via Phabricator via llvm-commits]

uenoku created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This fixes https://bugs.llvm.org/show_bug.cgi?id=41047.
IRBuilderBase::CreateMemCpy and similar functions are called in memcpy optimization(lib/Transforms/Scalar/MemCpyOptimizer.cpp). I think it is safe to enable tail call.


Repository:
  rL LLVM

https://reviews.llvm.org/D59534

Files:
  lib/IR/IRBuilder.cpp
  test/Transforms/MemCpyOpt/enable-tail-call.ll


Index: test/Transforms/MemCpyOpt/enable-tail-call.ll
===================================================================
--- /dev/null
+++ test/Transforms/MemCpyOpt/enable-tail-call.ll
@@ -0,0 +1,40 @@
+; RUN: opt -memcpyopt -S < %s | FileCheck %s
+
+target datalayout = "e-i64:64-f80:128-n8:16:32:64"
+target triple = "x86_64-unknown-linux-gnu"
+
+%S = type { i8*, i8, i32 }
+
+define void @copy(%S* %src, %S* %dst) {
+; CHECK-LABEL: copy
+; CHECK-NOT: load
+; CHECK: tail call void @llvm.memmove.p0i8.p0i8.i64
+; CHECK-NEXT: ret void
+  %1 = load %S, %S* %src
+  store %S %1, %S* %dst
+  ret void
+}
+
+define void @noaliassrc(%S* noalias %src, %S* %dst) {
+; CHECK-LABEL: noaliassrc
+; CHECK-NOT: load
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i64
+; CHECK-NEXT: ret void
+  %1 = load %S, %S* %src
+  store %S %1, %S* %dst
+  ret void
+}
+
+
+define void @destroysrc(%S* %src, %S* %dst) {
+; CHECK-LABEL: destroysrc
+; CHECK: load %S, %S* %src
+; CHECK: tail call void @llvm.memset.p0i8.i64
+; CHECK-NEXT: store %S %1, %S* %dst
+; CHECK-NEXT: ret void
+  %1 = load %S, %S* %src
+  store %S zeroinitializer, %S* %src
+  store %S %1, %S* %dst
+  ret void
+}
+
Index: lib/IR/IRBuilder.cpp
===================================================================
--- lib/IR/IRBuilder.cpp
+++ lib/IR/IRBuilder.cpp
@@ -107,6 +107,7 @@
   Function *TheFn = Intrinsic::getDeclaration(M, Intrinsic::memset, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   if (Align > 0)
     cast<MemSetInst>(CI)->setDestAlignment(Align);
@@ -138,6 +139,7 @@
       M, Intrinsic::memset_element_unordered_atomic, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   cast<AtomicMemSetInst>(CI)->setDestAlignment(Align);
 
@@ -169,6 +171,7 @@
   Function *TheFn = Intrinsic::getDeclaration(M, Intrinsic::memcpy, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   auto* MCI = cast<MemCpyInst>(CI);
   if (DstAlign > 0)
@@ -211,6 +214,7 @@
       M, Intrinsic::memcpy_element_unordered_atomic, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   // Set the alignment of the pointer args.
   auto *AMCI = cast<AtomicMemCpyInst>(CI);
@@ -249,6 +253,7 @@
   Function *TheFn = Intrinsic::getDeclaration(M, Intrinsic::memmove, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   auto *MMI = cast<MemMoveInst>(CI);
   if (DstAlign > 0)
@@ -287,6 +292,7 @@
       M, Intrinsic::memmove_element_unordered_atomic, Tys);
 
   CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CI->setTailCall(true);
 
   // Set the alignment of the pointer args.
   CI->addParamAttr(0, Attribute::getWithAlignment(CI->getContext(), DstAlign));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59534.191255.patch
Type: text/x-patch
Size: 2804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190319/c0038398/attachment.bin>