[PATCH] D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place

[Zixuan Wu via Phabricator via llvm-commits]

wuzish marked 4 inline comments as done.
wuzish added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/mul-const-vector.ll:9
+; CHECK-LABEL: test1_v16i8:
+; CHECK: vspltisb v[[REG1:[0-9]+]], 4
+; CHECK-NOT: vmul
----------------
jsji wrote:
> Looks like `vsplitsb`/`xxsplitb` is the only difference for P8/P9, you might be better using common prefixes to share (and reduce) checks.
> 
> ```
> ... -mcpu=pwr9 ... --check-prefixes=CHECK,CHECK-P9
> ... -mcpu=pwr8 --check-prefixes=CHECK,CHECK-P8
> 
> ; CHECK-LABEL: test1_v16i8:
> ; CHECK-P8:vspltisb v[[REG1:[0-9]+]], 4
> ; CHECK-P9: xxspltib v[[REG1:[0-9]+]], 4
> ; CHECK-NOT: vmul
> ; CHECK-NEXT: vslb v[[REG2:[0-9]+]], v2, v[[REG1]]
> 
> ```
Thank you. It's good to know the usage of two prefixes. --check-prefixes=CHECK,CHECK-P8


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58950/new/

https://reviews.llvm.org/D58950