[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

Mon Mar 18 20:38:21 PDT 2019

xiangzhangllvm added a comment.

In D58102#1428198 <https://reviews.llvm.org/D58102#1428198>, @ruiu wrote:

> But gold already has options, `-z ibt` and `-z ibtplt`. You should be consistent with these options, shouldn't we?

Yes, I think we should, and I think it's better to support these test options in a independent patch, and it's easy to support.

> What's going to happen if you specify these options to gold and some input files lack special marker `.note` section? Does the gold linker silently create an executable that won't work, or does it reject with an error message?

Yes, I test it, it will directly create '.note.gnu.property' section or 'splt', create an executable that won't work, and give no errors.
So it just used for test.
What your idea here?

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102