[PATCH] D59375: Allow unordered loads to be considered invariant in CodeGen

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 14:57:28 PDT 2019


jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.

LGTM modulo jfb's outstanding comment.



================
Comment at: lib/CodeGen/MachineInstr.cpp:1318
+      // instruction.  Such an instruction is technically an invariant load,
+      // but the caller code would need updated to expect that.
+      return false;
----------------
"need to be updated"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59375/new/

https://reviews.llvm.org/D59375





More information about the llvm-commits mailing list