[PATCH] D59262: [scudo][standalone] Add string utility functions

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 13:48:44 PDT 2019


vitalybuka added inline comments.


================
Comment at: lib/scudo/standalone/string_utils.h:34
+private:
+  Vector<char> String;
+  uptr Length;
----------------
cryptoad wrote:
> vitalybuka wrote:
> > If you use LLVM style, members go before methods
> Ack. I will revisit that later on.
> I'd like to land what is there for now, as Phabricator is quickly making this unreadable, if that's ok with you.
lgtm


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59262/new/

https://reviews.llvm.org/D59262





More information about the llvm-commits mailing list