[PATCH] D59506: [ValueTracking][InstSimplify] Support min/max selects in computeConstantRange()

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5663
+  const Value *LHS, *RHS;
+  SelectPatternResult R = matchSelectPattern(&SI, LHS, RHS);
+  if (R.Flavor == SPF_UNKNOWN)
----------------
`matchSelectPattern()` is the likely-costly bit.
(though it //seems// to be only a lot of pattern-matching, nothing more costly)

The rest of `setLimitsForSelect()` is rater cheap.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5686
+      break;
+    default:
+      break;
----------------
No `SPF_ABS` / `SPF_[N]ABS` ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59506/new/

https://reviews.llvm.org/D59506