[PATCH] D59262: [scudo][standalone] Add string utility functions

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 12:47:59 PDT 2019


morehouse added inline comments.


================
Comment at: lib/scudo/standalone/string_utils.h:32
+  }
+  void append(const char *Format, va_list Args);
+  void append(const char *Format, ...);
----------------
cryptoad wrote:
> morehouse wrote:
> > Why do we need this append with `va_list`?
> Printf for example uses a va_list for append. The variadic version is a wrapper to this one as well.
It looks like we only use `void append(const char *Format, ...)`.

Are there cases where `void append(const char *Format, va_list Args)` is used?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59262/new/

https://reviews.llvm.org/D59262





More information about the llvm-commits mailing list