[PATCH] D58068: [DAG] Avoid smart constructor-based dangling nodes.

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

Could you add a comment to the CL description noting that a bunch of the calls to AddToWorklist in DAGCombiner.cpp that follow a DAG.getNode() are now redundant, and should be cleaned up in the future.



================
Comment at: llvm/test/CodeGen/X86/3addr-or.ll:21
+
+; FIXME: anyextends into a constant and mask should be folded. 
 define i64 @test2(i8 %A, i8 %B) nounwind {
----------------
These are all due to PR40881? Please add PR references to all the FIXME comments if possible.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58068/new/

https://reviews.llvm.org/D58068