[PATCH] D59130: [llvm][Support] Provide interface to set thread priorities

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 12:15:54 PDT 2019


jfb added a comment.

In D59130#1433474 <https://reviews.llvm.org/D59130#1433474>, @jkorous wrote:

> Gotchas and symptoms are IMO dependent on the use-case. Since this is a generic API I'd say that documenting the behavior is the best we can do here.
>
> So how about @kadircet just adds a note to the header that platform specific details might be important here (depending on the use-case) and that more information is in comments in relevant implementation? Is that what you mean @jfb?


Realistically nobody reads the comments, so I'm OK not having them. I just want to know that @kadircet read the documentation for the platform-specific APIs being introduced, and has reasonable suspicion that no gotcha is being introduced.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59130/new/

https://reviews.llvm.org/D59130





More information about the llvm-commits mailing list