[PATCH] D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 12:04:07 PDT 2019


yln created this revision.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.

bool GetRealFunctionAddress(const char *func_name, uptr *func_addr,

  uptr real, uptr wrapper)

This function has evolved over the years. Comment about return value is
lying. Paramters real/wrapper don't make much sense and are not supplied
at any call site. Real return type is never used.

Refactored to be consistent with GetFuncAddrVer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59504

Files:
  compiler-rt/lib/interception/interception_linux.cc
  compiler-rt/lib/interception/interception_linux.h
  compiler-rt/lib/interception/tests/interception_linux_test.cc
  compiler-rt/lib/tsan/rtl/tsan_interceptors.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59504.191139.patch
Type: text/x-patch
Size: 5825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190318/539479c5/attachment.bin>


More information about the llvm-commits mailing list