[PATCH] D59351: [llvm-objcopy] Add --update-section

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a subscriber: pcc.
rupprecht added a reviewer: jakehehrlich.
rupprecht added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:781
   uint64_t SecSize = Section.Size ? Section.Size : 1;
-  return Segment.Offset <= Section.OriginalOffset &&
-         Segment.Offset + Segment.FileSize >= Section.OriginalOffset + SecSize;
+  return (Section.Flags & ELF::SHF_ALLOC) &&
+         Segment.Offset <= Section.OriginalOffset &&
----------------
@pcc has a similar change for this: D58426

I didn't totally grep that change either, but since you've independently come to the same conclusion, something like this is probably correct.


================
Comment at: tools/llvm-objcopy/ELF/Object.h:322
+  const SectionBase *lastSection() const {
+    return Sections.empty() ? nullptr : *(--Sections.end());
+  }
----------------
*Sections.rbegin() is slightly simpler


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59351/new/

https://reviews.llvm.org/D59351