[PATCH] D59174: [DAGCombine] Fold (x & ~y) | y patterns

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 06:50:51 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:5418-5419
 
   if (SDValue Combined = visitORLike(N0, N1, N))
     return Combined;
 
----------------
Actually, there already is this function, but it is only called in one order.
I suppose a follow-up to move contents of `visitORCommutative()` into `visitORLike()`,
and calling `visitORLike()` second time may be a good idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59174/new/

https://reviews.llvm.org/D59174





More information about the llvm-commits mailing list