[PATCH] D59468: [X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86Disassembler.cpp:472
-      default: llvm_unreachable("unexpected opcode");
-      case X86::VCMPPDrmi:   NewOpc = X86::VCMPPDrmi_alt;   break;
-      case X86::VCMPPDrri:   NewOpc = X86::VCMPPDrri_alt;   break;
----------------
I should note this list was very incomplete. If any of the masked forms were disassembled with an out of range immediate, an assertion would be thrown. Same for broadcast verisons with and without masking


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59468/new/

https://reviews.llvm.org/D59468