[PATCH] D59396: [MsgPack] Attempt to fix failure on windows expensive checks bot

[Tim Renouf via Phabricator via llvm-commits]

tpr updated this revision to Diff 190955.
tpr marked an inline comment as done.
tpr added a comment.

V3: Adjusted the MIR roundtrip fix to use scoping instead of explicit flush.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59396/new/

https://reviews.llvm.org/D59396

Files:
  lib/BinaryFormat/MsgPackDocumentYAML.cpp
  lib/Target/AMDGPU/SIMachineFunctionInfo.cpp


Index: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
===================================================================
--- lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
+++ lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
@@ -323,8 +323,10 @@
 static yaml::StringValue regToString(unsigned Reg,
                                      const TargetRegisterInfo &TRI) {
   yaml::StringValue Dest;
-  raw_string_ostream OS(Dest.Value);
-  OS << printReg(Reg, &TRI);
+  {
+    raw_string_ostream OS(Dest.Value);
+    OS << printReg(Reg, &TRI);
+  }
   return Dest;
 }
 
Index: lib/BinaryFormat/MsgPackDocumentYAML.cpp
===================================================================
--- lib/BinaryFormat/MsgPackDocumentYAML.cpp
+++ lib/BinaryFormat/MsgPackDocumentYAML.cpp
@@ -61,7 +61,7 @@
     llvm_unreachable("not scalar");
     break;
   }
-  return S;
+  return OS.str();
 }
 
 /// Convert the StringRef and use it to set this DocNode (assuming scalar). If


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59396.190955.patch
Type: text/x-patch
Size: 953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190316/38bfe0a1/attachment.bin>