[PATCH] D59444: [GlobalISel] Change MachineIRBuilder's SrcOp to contain subregister info

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 15 19:10:58 PDT 2019


aemerson added a comment.

In D59444#1431750 <https://reviews.llvm.org/D59444#1431750>, @arsenm wrote:

> I would think we would want to avoid any subregister indexes until as late as possible. Does the verifier reject them for G_* instructions?


In practice yes we’d only really use this during selection, but if someone did want to use MachineIRBuilder for emitting copies (as we do in arm64), it should be safe w.r.t CSE as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59444/new/

https://reviews.llvm.org/D59444





More information about the llvm-commits mailing list