[PATCH] D54647: [WebAssembly] Initial implementation of -fPIC codegeneration

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSymbolWasm.h:21
   bool IsComdat = false;
+  mutable bool IsUsedInGOT = false;
   Optional<std::string> ImportModule;
----------------
{meme, src=ohno, below=mutable}

sad how often `mutable` is used in LLVM. I guess maybe it means we're too aggressive about `const` overall?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54647/new/

https://reviews.llvm.org/D54647