[PATCH] D59417: [GVN] Add default debug location when constructing PHI nodes

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 15 10:58:14 PDT 2019


dblaikie added a comment.

In D59417#1431042 <https://reviews.llvm.org/D59417#1431042>, @probinson wrote:

> I believe this is a patch to fix PR37964?


Hrm - if debugify diagnoses all instances of instructions without locations as buggy, that sounds very noisy to me. How does it handle all the other cases of merged locations that end up with no location? (if my recollection is accurate and the code is still doing this - merged locations that aren't the same and that aren't calls get no location, not a zero location)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59417/new/

https://reviews.llvm.org/D59417





More information about the llvm-commits mailing list