[PATCH] D58915: [AArch64] Refactor floating point materialization. NFC

Fri Mar 15 08:41:23 PDT 2019

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:124
+  for (auto &I : Insn) {
+    bool LastItem = false;
+    switch (I.Opcode)
----------------
zatrazz wrote:
> efriedma wrote:
> > Is LastItem supposed to be set somewhere?  Why isn't it used for AArch64::ORRXri?
> It should be set for last item iteration, I will fix it. And my understanding why it is not set fo AArch64::ORRXri is the register used is always WZR/XZR. 
Isn't the point here to try to preserve the "dead" flag?  How is the operand related?

But if this actually matches the existing behavior, we can leave it for now, and clean it up later.  (If the destination is actually dead, there's a much simpler way to expand the instruction... by emitting nothing at all.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58915/new/

https://reviews.llvm.org/D58915