[PATCH] D59398: [X86] Remove the _alt forms of XOP VPCOM instructions. Use a combination of custom printing and custom parsing to achieve the same result and more

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 15 03:59:46 PDT 2019


RKSimon added inline comments.


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2517
+  // Push the immediate if we extracted one from the mnemonic.
+  if (ComparisonCode != ~0U && !isParsingIntelSyntax()) {
+    const MCExpr *ImmOp = MCConstantExpr::create(ComparisonCode,
----------------
Is the plan to reuse this for the upcoming vcmpps/pd/ss/sd support?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59398/new/

https://reviews.llvm.org/D59398





More information about the llvm-commits mailing list