[PATCH] D59033: [llvm-objcopy] Make .build-id linking atomic

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I just do not feel I am a good person to review/accept that, overall looks OK for my eye though,
a minor nit/question/suggestion is inline.



================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:214
+    TmpPath.push_back('\0');
+    return makeStringError(EC, "could not remove %s", TmpPath.data());
   }
----------------
Seems here and above you could use `SmallString::c_str()`?

It's just implemented very close to this I think:

```
  const char* c_str() {
    this->push_back(0);
    this->pop_back();
    return this->data();
  }
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59033/new/

https://reviews.llvm.org/D59033