[PATCH] D56828: [ELF] Simplify RelRo, TLS, NOBITS section ranks and make RW PT_LOAD start with RelRo

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 20:20:35 PDT 2019


MaskRay marked 4 inline comments as done.
MaskRay added a comment.

The three tests are fixed in https://reviews.llvm.org/rLLD356229



================
Comment at: lld/trunk/test/ELF/pack-dyn-relocs-loop.s:12
 
 // This test is very sensitive to the exact section sizes and offsets,
 // so check that they don't change.
----------------
pcc wrote:
> Can you check that this test fails if you revert the change that added the test?
Done.

Have to use `-z norelro` to counteract layout change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56828/new/

https://reviews.llvm.org/D56828





More information about the llvm-commits mailing list