[PATCH] D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 16:05:13 PDT 2019


efriedma marked an inline comment as done.
efriedma added inline comments.


================
Comment at: lib/MC/MCDwarf.cpp:1857
+      });
+  for (auto I = FrameArrayX.begin(), E = FrameArrayX.end(); I != E;) {
     const MCDwarfFrameInfo &Frame = *I;
----------------
compnerd wrote:
> While you are in the area, mind just switching this over to a range-based for loop?
I looked at it briefly, but the iterators are used inside the loop to check whether the current CFE is the last one, so there isn't any easy way to express this as a range-based loop.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58266/new/

https://reviews.llvm.org/D58266





More information about the llvm-commits mailing list