[PATCH] D59193: [ConstantRange] Add overflow check helpers

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 15:54:00 PDT 2019


spatel accepted this revision.
spatel added a comment.

LGTM



================
Comment at: llvm/include/llvm/IR/ConstantRange.h:331
+  /// Return whether unsigned add of the two ranges always/never overflows.
+  OverflowResult unsignedAddMayOverflow(const ConstantRange &other) const;
+
----------------
other -> Other ? 

(hoping we can standardize to camelCase variables, but we're not there yet?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59193/new/

https://reviews.llvm.org/D59193





More information about the llvm-commits mailing list