[PATCH] D59375: Allow unordered loads to be considered invariant in CodeGen

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 11:23:34 PDT 2019


jfb added a comment.

This part isn't something I've very familiar with, better if someone else reviews.



================
Comment at: lib/CodeGen/MachineInstr.cpp:1319
+      // but the caller code would need updated to expect that.
+      return false;
     if (MMO->isStore()) return false;
----------------
Do you ever have volatile unordered?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59375/new/

https://reviews.llvm.org/D59375





More information about the llvm-commits mailing list