[PATCH] D59356: [SelectionDAGBuilder] Use accumulator value in VECREDUCE_FADD/FMUL

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 11:02:20 PDT 2019


sdesmalen added a comment.

@nikic thanks for pointing me to that discussion! I clearly misread the LangRef for this change :)
I agree it makes more sense to change these intrinsics and to make its accumulator argument always relevant (regardless of what flags are set) and AutoUpgrading older IR. Given that I'm currently working on this, I'd be happy to move this forward with patches and a proposal/discussion on the mailing list to change the experimental reduction intrinsics. @aemerson you expressed an intention to work on it later this year, do you have any objection to me moving forward with this now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59356/new/

https://reviews.llvm.org/D59356





More information about the llvm-commits mailing list