[PATCH] D59343: [WebAssembly] Use passive segments when memory is shared

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 09:07:28 PDT 2019


sbc100 added a comment.

Mostly lgtm



================
Comment at: lld/test/wasm/data-segment-merging.ll:12
 ; RUN: llc -filetype=obj %s -o %t.data-segment-merging.o
+; RUN: llc -filetype=obj %s -o %t.data-segment-merging.atomics.o -mattr=+atomics
 
----------------
The code looks like passive initiazlition is driver by the "--shared-memory" flag rather than atomics.   Wouldn't it make more sense to use "SHARED" over "ATOMICS" in this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59343/new/

https://reviews.llvm.org/D59343





More information about the llvm-commits mailing list