[PATCH] D59277: Speeding up llvm-cov with multithreaded renderFiles.

Thu Mar 14 07:24:12 PDT 2019

Dor1s accepted this revision.
Dor1s added a comment.
This revision is now accepted and ready to land.

In D59277#1428472 <https://reviews.llvm.org/D59277#1428472>, @sajjadm wrote:

> Thanks for all the feedback, Max and Vedant!
>
> @Dor1s , do you still find the comparison function confusing now that it's a lambda? It's meant to return a boolean in the manner expected by std::sort. True if the left argument is "less" than the right argument, and false otherwise.

As lambda comparator it totally makes sense.

The change looks good to me! Let's wait for a final approval by @vsk and then I can commit it for you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59277/new/

https://reviews.llvm.org/D59277