[PATCH] D58599: [LLD] Add summary support

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 06:00:47 PDT 2019


aganea updated this revision to Diff 190609.
aganea added a comment.

In D58599#1428277 <https://reviews.llvm.org/D58599#1428277>, @ruiu wrote:

> Yes, I don't think we need `Suymmary` class. I'd really like to avoid creating a generic infrastructure too far ahead of time. If we would like to print out stuff all at once at the end of the process in the future, we'll be able to easily do that and change the existing code to print out to that output buffer instead of `out()`.


Ok, once you've mentionned `outs()` it made everything clear, and I agree. I'll keep that in mind for potential upgrades, if need arises.
In the meanwhile, please see the updated code.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599

Files:
  COFF/Config.h
  COFF/Driver.cpp
  COFF/Options.td
  COFF/PDB.cpp
  test/COFF/pdb-type-server-simple.test
  test/COFF/precomp-link.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58599.190609.patch
Type: text/x-patch
Size: 7384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190314/3870f94f/attachment.bin>


More information about the llvm-commits mailing list