[PATCH] D59293: [llvm-objcopy]Don't implicitly strip sections in segments

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 03:06:53 PDT 2019


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-all-gnu.test:10
+# RUN: llvm-objcopy %t %t4
+# RUN: od %t4 -t x1 -N 4 -j 120 | FileCheck %s --check-prefix=COPY-BYTES
+# RUN: od %t2 -t x1 -N 4 -j 120 | FileCheck %s --check-prefix=STRIP-BYTES
----------------
jakehehrlich wrote:
> rupprecht wrote:
> > Does `od` work on windows?
> We've been using in practice so...I think so?
Yes, `od` is part of GnuWin32, which is a pre-requisite for running the lit tests on Windows.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59293/new/

https://reviews.llvm.org/D59293





More information about the llvm-commits mailing list