[PATCH] D59188: [DAGCombine] Fold insert_subvector(bitcast(x),bitcast(y)) -> bitcast(insert_subvector(x,y))

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 14:38:18 PDT 2019


nikic added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18266
+        NewVT = EVT::getVectorVT(Ctx, N1SrcSVT, NumElts * Scale);
+        NewIdx = DAG.getIntPtrConstant(InsIdx * Scale, DL);
+      } else if ((N1SrcSVT.getSizeInBits() % EltSizeInBits) == 0) {
----------------
Should use getVectorIdxTy?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59188/new/

https://reviews.llvm.org/D59188





More information about the llvm-commits mailing list