[PATCH] D58919: WebAssembly: Irreducible control flow rewrite

[Alon Zakai via Phabricator via llvm-commits]

kripken updated this revision to Diff 190491.
kripken marked 2 inline comments as done.
kripken added a comment.

Various changes from the feedback:

- Change how the LoopBlocks work list works, using a set+vector instead of just a set.
- Move large functions out of the class definition.
- Avoid a move in MutualEntries, instead have them always contain all the mutual entries (which includes the original entry, as it is mutual to itself).
- Test cleanup; use -O0 for the main irreducibility tests; remove old irreducibility tests which were invalid.
- Comment improvements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58919/new/

https://reviews.llvm.org/D58919

Files:
  lib/Target/WebAssembly/WebAssemblyFixIrreducibleControlFlow.cpp
  test/CodeGen/WebAssembly/irreducible-cfg-nested.ll
  test/CodeGen/WebAssembly/irreducible-cfg-nested2.ll
  test/CodeGen/WebAssembly/irreducible-cfg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58919.190491.patch
Type: text/x-patch
Size: 33582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190313/491741ee/attachment.bin>