[PATCH] D59033: [llvm-objcopy] Make .build-id linking atomic

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 13:44:00 PDT 2019


jakehehrlich added inline comments.


================
Comment at: llvm/include/llvm/Support/FileSystem.h:770
+/// Generates a unique path suitable for a temporary file but does not
+/// open or create the file. The name is based on \a model with '%'
+/// replaced by a random char in [0-9a-f]. If \a MakeAbsolute is true
----------------
jhenderson wrote:
> model -> Model, I assume to match the variable name?
Sorry I had a draft comment about this and was waiting to post it once I uploaded context....and then I just didn't; whoops.

The comments were just copied from the documentation below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59033/new/

https://reviews.llvm.org/D59033





More information about the llvm-commits mailing list