[PATCH] D59237: [WebAssembly] Improve support for "needed" list in dylink section

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with the previous comments fixed.



================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:327
   // See https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md
+  HasDylinkSection = true;
   DylinkInfo.MemorySize = readVaruint32(Ctx);
----------------
sbc100 wrote:
> ruiu wrote:
> > Is this dead code?
> Its fixing a bug that isSharedLibrary(), which is only ever used by lld, was always returning false.
> 
> I guess at least some other tool such as objdump should probably be calling that and displaying different output for shared libs.
Got it. We eventually need a test, but it doesn't have to be at this time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59237/new/

https://reviews.llvm.org/D59237