[PATCH] D59277: Speeding up llvm-cov with multithreaded renderFiles.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 10:40:16 PDT 2019


vsk added inline comments.


================
Comment at: llvm/tools/llvm-cov/CoverageExporterJson.cpp:220
+                           Options.ExportSummaryOnly, Options.SkipExpansions);
+  std::sort(Files.begin(), Files.end(), compareFileJson);
+  auto Export = json::Object(
----------------
As this is the only use of the comparator, consider passing in a lambda which consumes `const json::Object &` parameters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59277/new/

https://reviews.llvm.org/D59277





More information about the llvm-commits mailing list