[PATCH] D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 10:08:12 PDT 2019


saugustine added a comment.

rsmith: Do you have any comments on the naming here?

"--unwindlib=compiler-rt" has the disadvantage that the llvm-unwind lib isn't inside compiler-rt (although there are hints of moving it there).

Using --unwindlib="some-string-passed-exactly-as-is-to-the-linker" cannot work because we should use "-lgcc_s" for some links and "-lgcc_eh" for others.

-lunwind has the disadvantage of picking up whatever libunwind happens to be first in the search path. Fixing that would require moving llvm-libunwind into compiler-rt and naming it differently.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59109/new/

https://reviews.llvm.org/D59109





More information about the llvm-commits mailing list