[PATCH] D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE

[Sarvesh Tamba via Phabricator via llvm-commits]

sarveshtamba added a comment.

Hi @dblaikie

Sorry for the delayed response.
Yes you are right, the submitted change would not effect the behavior of the program. I think I misread / misinterpreted the condition earlier, took it to be e = ++i, not realising its a simple for loop increment.
Also the error  that's being thrown up might be intermittent, since when I made this change from ++i to i++, the build seemed to have passed, though now it fails again.

Following is the output of the successful build of Apple Swift 5 toolchain on PowerPC64LE:-




  		"--- Creating installable package ---
  		-- Package file: /home/sar/swift-source/swift-LOCAL-2019-02-26-a-linux.tar.gz --
  		+ pushd /home/sar/swift-source/swift-nightly-install/
  		~/swift-source/swift-nightly-install ~/swift-source/swift
  		+ tar -c -z -f /home/sar/swift-source/swift-LOCAL-2019-02-26-a-linux.tar.gz --owner=0 --group=0 usr/
  		+ popd
  		~/swift-source/swift
  		-- Test Installable Package --
  		+ rm -rf /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le
  		+ mkdir -p /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le
  		+ pushd /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le
  		~/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le ~/swift-source/swift
  		+ tar xzf /home/sar/swift-source/swift-LOCAL-2019-02-26-a-linux.tar.gz
  		+ popd
  		~/swift-source/swift
  		+ pushd /home/sar/swift-source/swift-integration-tests
  		~/swift-source/swift-integration-tests ~/swift-source/swift
  		+ python /home/sar/swift-source/llvm/utils/lit/lit.py . -sv --param package-path=/home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le --param test-exec-root=/home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/tests --param llvm-bin-dir=/home/sar/swift-source/build/buildbot_linux/llvm-linux-powerpc64le/bin
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:131: note: testing package: '/home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le'
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:143: note: testing using 'FileCheck': '/home/sar/swift-source/build/buildbot_linux/llvm-linux-powerpc64le/bin/FileCheck'
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:144: note: testing using 'readelf': '/home/sar/swift-source/build/buildbot_linux/llvm-linux-powerpc64le/bin/llvm-readelf'
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:165: note: testing using swift benchmarks at path: /home/sar/swift-source/swift/benchmark
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:174: note: testing using 'swift': '/home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/swift'
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:179: note: testing using 'swiftc': '/home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/swiftc'
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:184: note: testing using 'lldb': /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/lldb
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:189: note: testing using 'repl_swift': /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/repl_swift
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:246: note: testing using 'sk-stress-test': /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/sk-stress-test
  		lit.py: /home/sar/swift-source/swift-integration-tests/lit.cfg:247: note: testing using 'sk-swiftc-wrapper': /home/sar/swift-source/build/buildbot_linux/none-swift_package_sandbox_linux-powerpc64le/usr/bin/sk-swiftc-wrapper
  		-- Testing: 27 tests, 8 threads --
  		Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
  		Testing Time: 74.27s
  		  Expected Passes    : 19
  		  Unsupported Tests  : 8
  		+ popd
  		~/swift-source/swift
  		Building the standard library for: swift-stdlib-linux-powerpc64le
  		Running Swift tests for: check-swift-all-linux-powerpc64le check-swift-all-optimize-linux-powerpc64le"




Any thoughts/inputs on the possible causes?

Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58712/new/

https://reviews.llvm.org/D58712